Fixed a bug where centering coefficients used in Magentostatic solver… #5289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… were not being initialized when doing an energy-conserving field gather. Signed-off-by: S. Eric Clark <[email protected]>
for more information, see https://pre-commit.ci
clarkse
added
bug
|
This should resolve issue #5242 |
|
To be rebased after #5296 is merged (will fix the |
|
I agree this will fix the B = 0 issue with non-Eb runs but the introduction of non-zero div B (as described in #5175) will still be there. We can merge this though and I'll try to get the follow-up PR cleaned up and ready to go over the next week or two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… were not being initialized when doing an energy-conserving field gather.