Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change submodule ( Motion ) path ( Sources/Frameworks -> Frameworks ) #1271

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

goodocy
Copy link

@goodocy goodocy commented Sep 23, 2019

Change submodule ( Motion ) path ( Sources/Frameworks -> Frameworks )

Package.swift - target - exclude does not work as intended

Reason
SPM (Swift Package Manager) does not support submodules, and when I checked it, I confirmed that when I updated the package, the material and motion conflict.
Currently CocoaPods, Carthage, and SPM are using Motion, so I suggest changing the Sources/Framework/Motion from the SPM management folder (Sources) to external.

@daniel-jonathan
Copy link
Member

@goodocy Thank you. I will read through this later today.

@goodocy
Copy link
Author

goodocy commented Sep 23, 2019

@DanielDahan Thank you for comment.
so, If the translation is strange or does not understand, please tell me.

@goodocy
Copy link
Author

goodocy commented Sep 23, 2019

Hmm... interesting
Proceed to another Mac, new project, no problem.

Problem:
Application.swift is Conflict because the Material/Sources/Framework/Motion folder is recognized in Xcode - Project Navigator - Swift Package Dependencies.

@daniel-jonathan
Copy link
Member

daniel-jonathan commented Sep 27, 2019

Hi @goodocy, sorry I haven't had a chance to look into this issue. I will make some changes that externalize the Motion submodule framework based on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants