Ask for > 5 digits of precision when solving linear system #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ranjanan this causes Omniscape to error out on tests with CHOLMOD if I recall correctly. Or is the division by the other matrix norm handling potential issues from before? (I guess that's the "relative" tolerance?) |
|
I looked at one of the problems that was causing an error at Circuitscape/Omniscape.jl#100 . I examined the solution that was failing and it looked fine. So I decided to tweak the error metric to ask for relative tolerance. |
|
Fixes Circuitscape/Omniscape.jl#99, and hopefully fixes Circuitscape/Omniscape.jl#100 too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the assert statement test relative tolerance instead of an arbitrary bound on the L2 resnorm