-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CGAL::IO::read_OM() #8427
base: master
Are you sure you want to change the base?
Add CGAL::IO::read_OM() #8427
Conversation
auto sm_efeature_pmap = boost::make_assoc_property_map(sm_efeature_map); | ||
|
||
// Try building a surface_mesh | ||
SMesh* SM = new SMesh(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SMesh* SM = new SMesh(); | |
SMesh* sm = new SMesh(); |
the name should be lower case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started from the STL plugin.
bool CGAL_Lab_om_plugin:: | ||
save(QFileInfo fileinfo,QList<CGAL::Three::Scene_item*>& items) | ||
{ | ||
#if 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#if 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saving a mesh in *.om
format is not yet done. It would be cleaner to reply false
in a can_save()
method.
/* | ||
operator OpenMesh::EdgeHandle () const { | ||
return OpenMesh::EdgeHandle(idx()); | ||
} | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should go to another pull request. The thing is that the edge_descriptor
we wrote cannot be passed to methods like status(e)
.
} // namespace IO | ||
} // namespace CGAL | ||
|
||
#endif // CGAL_IO_OM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing EOL
…s' into BGL-Openmesh_selection-GF # Conflicts: # BGL/examples/BGL_OpenMesh/CMakeLists.txt
In the demo, loading a .om file containing a surface mesh that has no feature vertices and no feature edges should not create a selection item. |
|
Failed in 6.0-Ic-327 and must be tested again. Fix is committed. |
Summary of Changes
Add a function to read an OpenMesh file (
*.om
) in CGALlab. This file format stores also edges and vertices marked as features.For the moment the function itself is not documented.
Release Management
FindOpenMesh.cmake
#8332