Hyperbolic surface triangulation 2 (new package) #8259

loic-dubois · 2024-06-05T10:32:31Z

Summary of Changes

This package enables building and handling triangulations of closed orientable hyperbolic surfaces: a basic tool for any future implementation of algorithms operating on such surfaces. Functionalities are offered such as the Delaunay flip algorithm, and the construction of a portion of the lift of the triangulation in the Poincaré disk model of the hyperbolic plane. Triangulations can be generated by triangulating a convex fundamental domain in the Poincaré disk. A method is offered that generates such domains in genus two.

Release Management

Affected package(s): Hyperbolic_surface_triangulation_2
Issue(s) solved (if any): -
Feature/Small Feature (if any): https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Hyperbolic_Surface_Triangulation
Link to compiled documentation: link
License and copyright ownership: GPL INRIA

Merge branch 'Hyperbolic_surface_triangulation_2-dubois' of github.com:CGAL/cgal-public-dev into Hyperbolic_surface_triangulation_2-dubois

…m:CGAL/cgal-public-dev into Hyperbolic_surface_triangulation_2-dubois

afabri · 2024-06-05T11:07:57Z

/build:v0

github-actions · 2024-06-05T11:10:33Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8259/v0/Manual/index.html

Hyperbolic_surface_triangulation_2/include/CGAL/Hyperbolic_fundamental_domain_2.h

sloriot · 2024-09-09T11:21:24Z

/force-build:v1

github-actions · 2024-09-09T11:29:33Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8259/v1/Manual/index.html

…m:loic-dubois/cgal into Hyperbolic_surface_triangulation_2-dubois

afabri · 2024-09-10T06:11:44Z

Hyperbolic_surface_triangulation_2/include/CGAL/Complex_without_sqrt.h

+////////////////////////////////////////////////////////////////////////////////
+
+template<class FT>
+Complex_without_sqrt<FT>::Complex_without_sqrt(){


Change to a member initializer list.

afabri · 2024-09-10T06:12:10Z

Hyperbolic_surface_triangulation_2/include/CGAL/Complex_without_sqrt.h

+////////////////////////////////////////////////////////////////////////////////
+
+template<class FT>
+FT Complex_without_sqrt<FT>::real_part() const{


Suggested change

FT Complex_without_sqrt<FT>::real_part() const{

const FT& Complex_without_sqrt<FT>::real_part() const{

afabri · 2024-09-10T06:18:06Z

Hyperbolic_surface_triangulation_2/include/CGAL/Hyperbolic_isometry_2.h

+  void set_coefficient(int index, const Complex_number& coefficient);
+
+  // Returns the index-th coefficient
+  Complex_number get_coefficient(int index) const;


return const&

afabri · 2024-09-10T06:22:58Z

Hyperbolic_surface_triangulation_2/include/CGAL/Hyperbolic_surface_triangulation_2.h

+      _combinatorial_map.mark(const_ccw(invaded), visited_darts_mark);
+      _combinatorial_map.mark(const_cw(invaded), visited_darts_mark);
+
+      Point a = positions[const_ccw(invader)];


make points a,b, and c const&

afabri · 2024-09-11T06:54:00Z

/force-build:v1

github-actions · 2024-09-11T06:56:26Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8259/v1/Manual/index.html

afabri · 2024-09-11T07:17:12Z

@loic-dubois @pougetma What is not offered by std::complex for that you come up with your own class ?

…m:loic-dubois/cgal into Hyperbolic_surface_triangulation_2-dubois

afabri · 2024-09-11T12:34:51Z

...tion_2/doc/Hyperbolic_surface_triangulation_2/CGAL/Hyperbolic_fundamental_domain_factory_2.h

-Factory class, whose purpose is to generate some convex domains of surfaces of genus two.
+Factory class, whose only purpose is to construct random fundamental domains of
+closed orientable hyperbolic surfaces. The method
+make_hyperbolic_fundamental_domain_g2 constructs such a domain for a surface of


backtick the function.

loic-dubois · 2024-09-11T15:06:12Z

@loic-dubois @pougetma What is not offered by std::complex for that you come up with your own class ?

We represent each complex number by the pair of its real and imaginary parts. We require that the number type of the real and imaginary parts supports the basic arithmetic operations +, -, *, /, and computes them exactly (without any rounding). But we dot not require anything else. In particular, we do not want to use square roots or things like that. This is a constraint that we chose, hoping that it would make computations faster.

So for example, if we were to use CGAL:Gmpq for the real and imaginary parts, then we could represent the complex number 1 + i, but we should not be able to compute its norm (for it is not a rational number).

But then std::complex has methods like "norm" or "arg". So I guess that std::complex, templated by CGAL:Gmpq, should not even compile?

afabri · 2024-09-12T14:17:25Z

@pougetma can you please configure your text editor that it does remove trailing white space. And remove the current WS.

pougetma · 2024-09-13T07:40:01Z

@loic-dubois @pougetma What is not offered by std::complex for that you come up with your own class ?

We represent each complex number by the pair of its real and imaginary parts. We require that the number type of the real and imaginary parts supports the basic arithmetic operations +, -, *, /, and computes them exactly (without any rounding). But we dot not require anything else. In particular, we do not want to use square roots or things like that. This is a constraint that we chose, hoping that it would make computations faster.

So for example, if we were to use CGAL:Gmpq for the real and imaginary parts, then we could represent the complex number 1 + i, but we should not be able to compute its norm (for it is not a rational number).

But then std::complex has methods like "norm" or "arg". So I guess that std::complex, templated by CGAL:Gmpq, should not even compile?

It seems to me that std::complex is fine as a model for the concept
ComplexWithoutSqrt, (note that the "norm" is in fact the squared modulus).
We "only" have to modify the member names of our concept so that it fits the
one we need from std::complex. But the fact that sdt::complex provides more is
not a pb.

afabri · 2024-09-13T07:55:04Z

We "only" have to modify the member names of our concept so that it fits the
one we need from std::complex. But the fact that sdt::complex provides more is
not a pb.

I would suggest to switch to std::complex then. The less we have to maintain because it is offered by std:: types, the better.
With the functions to change, I guess you mean std::complex::imag(). I agree.

loic-dubois and others added 19 commits March 7, 2024 08:16

initialisation

72405a4

Ajout du code

449cfa4

remplissage du README

a3b1e0f

bug fix

4ee74ee

changed cmap copy into copy from const

3aab28f

version 0 de la doc

c1eb7f0

new point type

e799290

documentation almost finished up to user manual

6b424b1

user manual

3d1d728

finished with user manual

1f1ca86

add non-separating

471b3bb

doc improvement

497c88a

doc update

263f7ea

added an explicit cast since my compiler complains

f794cd9

Merge branch 'Hyperbolic_surface_triangulation_2-dubois' of github.com:CGAL/cgal-public-dev into Hyperbolic_surface_triangulation_2-dubois

doc update

d10f85d

Merge branch 'Hyperbolic_surface_triangulation_2-dubois' of github.co…

f72fa67

…m:CGAL/cgal-public-dev into Hyperbolic_surface_triangulation_2-dubois

update doc 2

dec801d

update

0eae2cf

minor patches

c4eea02

MaelRL added Not yet approved The feature or pull-request has not yet been approved. Feature labels Jun 5, 2024

MaelRL added this to the 6.1-beta milestone Jun 5, 2024

MaelRL changed the title ~~Hyperbolic surface triangulation 2 dubois~~ Hyperbolic surface triangulation 2 (new package) Jun 5, 2024

Fix dependencies

88576a0

afabri reviewed Jun 5, 2024

View reviewed changes

Hyperbolic_surface_triangulation_2/include/CGAL/Hyperbolic_fundamental_domain_2.h Outdated Show resolved Hide resolved

afabri reviewed Jun 5, 2024

View reviewed changes

Hyperbolic_surface_triangulation_2/include/CGAL/Hyperbolic_fundamental_domain_2.h Outdated Show resolved Hide resolved

afabri reviewed Jun 5, 2024

View reviewed changes

Hyperbolic_surface_triangulation_2/include/CGAL/Hyperbolic_fundamental_domain_2.h Outdated Show resolved Hide resolved

afabri reviewed Jun 5, 2024

View reviewed changes

Hyperbolic_surface_triangulation_2/include/CGAL/Hyperbolic_fundamental_domain_2.h Outdated Show resolved Hide resolved

afabri added 3 commits September 9, 2024 11:28

Remove 'can be used'

cb258c8

Remove using namespace CGAL

6557673

HyperbolicSurfaces -> HyperbolicSurface

009dbca

This comment was marked as outdated.

Sign in to view

pougetma and others added 4 commits September 9, 2024 15:13

Corrections of Andreas review

b4264b5

Merge branch 'Hyperbolic_surface_triangulation_2-dubois' of github.co…

8f2609f

…m:loic-dubois/cgal into Hyperbolic_surface_triangulation_2-dubois

hopefully last revision for 1st review round

002b807

cleanup

2dacabc

afabri reviewed Sep 10, 2024

View reviewed changes

afabri and others added 4 commits September 11, 2024 08:45

capitalize

6d276ec

remove dep

9c26e03

corrected CamelCase

1eed742

Merge branch 'Hyperbolic_surface_triangulation_2-dubois' of github.co…

418fa22

…m:loic-dubois/cgal into Hyperbolic_surface_triangulation_2-dubois

afabri reviewed Sep 11, 2024

View reviewed changes

pougetma added 2 commits September 11, 2024 16:25

backticked

1226b8d

constification

0596b67

rm whitespace

f32e5c4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hyperbolic surface triangulation 2 (new package) #8259

Hyperbolic surface triangulation 2 (new package) #8259

loic-dubois commented Jun 5, 2024 •

edited by afabri

Loading

afabri commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

This comment was marked as outdated.

This comment was marked as outdated.

sloriot commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

afabri Sep 10, 2024

afabri Sep 10, 2024

pougetma Sep 12, 2024

afabri Sep 10, 2024

pougetma Sep 11, 2024

afabri Sep 10, 2024 •

edited

Loading

pougetma Sep 12, 2024

afabri commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

afabri commented Sep 11, 2024

afabri Sep 11, 2024

pougetma Sep 12, 2024

loic-dubois commented Sep 11, 2024 •

edited

Loading

afabri commented Sep 12, 2024

pougetma commented Sep 13, 2024

afabri commented Sep 13, 2024

	FT Complex_without_sqrt<FT>::real_part() const{
	const FT& Complex_without_sqrt<FT>::real_part() const{

Hyperbolic surface triangulation 2 (new package) #8259

Are you sure you want to change the base?

Hyperbolic surface triangulation 2 (new package) #8259

Conversation

loic-dubois commented Jun 5, 2024 • edited by afabri Loading

Summary of Changes

Release Management

afabri commented Jun 5, 2024

github-actions bot commented Jun 5, 2024

This comment was marked as outdated.

This comment was marked as outdated.

sloriot commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afabri Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afabri commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

afabri commented Sep 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

loic-dubois commented Sep 11, 2024 • edited Loading

afabri commented Sep 12, 2024

pougetma commented Sep 13, 2024

afabri commented Sep 13, 2024

loic-dubois commented Jun 5, 2024 •

edited by afabri

Loading

afabri Sep 10, 2024 •

edited

Loading

loic-dubois commented Sep 11, 2024 •

edited

Loading