Updated icon4py and gt4py tags #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spack-c2sm into new_september_tag_addition
…ptember_tag_addition
|
launch jenkins all |
|
jonasjucker
reviewed
Sep 12, 2024
| @@ -19,6 +19,7 @@ class PyGt4py(PythonPackage): | |||
| version('1.0.3.3', tag='icon4py_20240229', git=url) | |||
| version('1.0.3.7', tag='icon4py_20240521', git=url) | |||
| version('1.0.3.8', tag='icon4py_20240711', git=url) | |||
There was a problem hiding this comment.
This version is untested. I recommend to either include it in testing, or remove from the recipe.
No need to carry this on.
|
launch jenkins all |
|
launch jenkins all |
balfrin🟢 unit test
🟢 integration test
🔴 system test
|
balfrin🟢 unit test
🟢 integration test
🔴 system test
|
|
You might be able to iterate faster if you run specific tests in your IDE or via command line. This saves you the roundtrip via Git, GitHub, Jenkins, and you can see the test being executed live. then launching a test is a matter of pushing a button |
|
I see we never triggered the tests on the latest commit e722e15 which is supposed to work: I've tested it locally. The reason why the previous commit failed was that it was still missing the spack version for |
|
launch jenkins all |
balfrin🟢 unit test
🟢 integration test
🟢 system test
|
dominichofer
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
icon4py:
v.0.0.13gt4py:
icon4py_20240911