Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py2f]: Add dycore wrapper and datatest #508

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Conversation

huppd
Copy link
Contributor

@huppd huppd commented Jul 16, 2024

Description

Adds dycore wrapper and datatest for single and multitimestep runs. The Fortran integration test is skipped for now as we need to pass the correct connectivities from Fortran in order to initialise the ICON grid on the Python side. In the future this may be achieved using serialised connectivities and using Serialbox to read them in on the Fortran side.

samkellerhals and others added 2 commits August 9, 2024 14:13
Fixes for running dycore on gpu
---------

Co-authored-by: Jonas Jucker <[email protected]>
Co-authored-by: Nicoletta Farabullini <[email protected]>
@samkellerhals
Copy link
Contributor

cscs-ci run default

@samkellerhals
Copy link
Contributor

cscs-ci run default

@samkellerhals
Copy link
Contributor

cscs-ci run default

@samkellerhals
Copy link
Contributor

launch jenkins spack

@samkellerhals
Copy link
Contributor

cscs-ci run default

@samkellerhals
Copy link
Contributor

cscs-ci run default

@samkellerhals
Copy link
Contributor

cscs-ci run default

@samkellerhals
Copy link
Contributor

launch jenkins spack

@samkellerhals
Copy link
Contributor

launch jenkins spack

@samkellerhals
Copy link
Contributor

cscs-ci run default

@samkellerhals
Copy link
Contributor

cscs-ci run default

@samkellerhals
Copy link
Contributor

launch jenkins spack

@samkellerhals samkellerhals removed the request for review from halungge September 11, 2024 08:21
Granule dycore which runs on CPU and GPU in ICON (not verifying yet), and passes datatests in icon4py.
@samkellerhals
Copy link
Contributor

cscs-ci run default

Resolved conflicts and also disabled Fortran integration tests, since we need to pass
connectivities now inorder for the granule to run correctly.
@samkellerhals
Copy link
Contributor

cscs-ci run default

@samkellerhals
Copy link
Contributor

cscs-ci run default

@samkellerhals
Copy link
Contributor

cscs-ci run default

@samkellerhals
Copy link
Contributor

cscs-ci run default

2 similar comments
@samkellerhals
Copy link
Contributor

cscs-ci run default

@samkellerhals
Copy link
Contributor

cscs-ci run default

@samkellerhals
Copy link
Contributor

cscs-ci run default

@samkellerhals samkellerhals changed the title Dycore wrapper hud [py2f]: Add dycore wrapper and datatest Sep 17, 2024
@samkellerhals samkellerhals marked this pull request as ready for review September 17, 2024 06:43
@samkellerhals
Copy link
Contributor

cscs-ci run default

@samkellerhals
Copy link
Contributor

cscs-ci run default

@samkellerhals
Copy link
Contributor

cscs-ci run default

Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants