Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-tables] Add support for Entra ID on Cosmos #31154

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Conversation

xirzec
Copy link
Member

@xirzec xirzec commented Sep 18, 2024

Packages impacted by this PR

@azure/data-tables

Issues associated with this PR

@kyle-patterson ?

Describe the problem that is addressed by this PR

Adds support for using the correct scope when receiving an auth challenge via a Cosmos endpoint.

I also fixed a central sanitizer issue that was impacting running the playback tests.

Are there test cases added in this PR? (If not, why?)

Yes

Provide a list of related PRs (if any)

Azure/azure-sdk-for-net#45934

@xirzec xirzec added Client This issue points to a problem in the data-plane of the library. Tables labels Sep 18, 2024
@xirzec xirzec self-assigned this Sep 18, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@maorleger maorleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, a test would be nice but I understand it may not be trivial

@xirzec xirzec changed the title [data-tables] Add support for Managed Identity [data-tables] Add support for Entra ID on Cosmos Sep 19, 2024
@xirzec
Copy link
Member Author

xirzec commented Sep 19, 2024

Changes LGTM, a test would be nice but I understand it may not be trivial

I added some tests just for you 😄

@xirzec xirzec merged commit d8c3984 into Azure:main Sep 19, 2024
14 checks passed
@xirzec xirzec deleted the tablesMI branch September 19, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Tables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants