Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable clean-up #93

Merged
merged 21 commits into from
Oct 9, 2023
Merged

Variable clean-up #93

merged 21 commits into from
Oct 9, 2023

Conversation

simonkurtz-MSFT
Copy link
Contributor

I'm starting a draft PR for comment before converting to a full PR.

We use ~40 variables throughout our workshop. Some are mixed case, some are uppercase. We often times also refer to variables we set in previous modules or higher up in the present module, which someone who is following our instructions must then locate and use its value.

This PR shall address a few items:

  1. Provide a listing of all variables that are used - set or empty
  2. Homogenize naming convention and casing
  3. Rename variables to explicitly identify their purpose

@simonkurtz-MSFT simonkurtz-MSFT self-assigned this Oct 9, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023 •
edited
Loading

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-09 17:41 UTC

@simonkurtz-MSFT simonkurtz-MSFT temporarily deployed to github-pages October 9, 2023 12:08 — with GitHub Actions Inactive
@simonkurtz-MSFT simonkurtz-MSFT temporarily deployed to github-pages October 9, 2023 14:51 — with GitHub Actions Inactive
@simonkurtz-MSFT simonkurtz-MSFT temporarily deployed to github-pages October 9, 2023 14:53 — with GitHub Actions Inactive
@simonkurtz-MSFT simonkurtz-MSFT temporarily deployed to github-pages October 9, 2023 14:55 — with GitHub Actions Inactive
@simonkurtz-MSFT simonkurtz-MSFT temporarily deployed to github-pages October 9, 2023 15:00 — with GitHub Actions Inactive
@simonkurtz-MSFT simonkurtz-MSFT temporarily deployed to github-pages October 9, 2023 15:06 — with GitHub Actions Inactive
@simonkurtz-MSFT simonkurtz-MSFT marked this pull request as ready for review October 9, 2023 15:09
@simonkurtz-MSFT simonkurtz-MSFT temporarily deployed to github-pages October 9, 2023 15:11 — with GitHub Actions Inactive
@simonkurtz-MSFT simonkurtz-MSFT temporarily deployed to github-pages October 9, 2023 16:18 — with GitHub Actions Inactive
@simonkurtz-MSFT simonkurtz-MSFT temporarily deployed to github-pages October 9, 2023 16:54 — with GitHub Actions Inactive
@simonkurtz-MSFT simonkurtz-MSFT temporarily deployed to github-pages October 9, 2023 16:57 — with GitHub Actions Inactive
@simonkurtz-MSFT simonkurtz-MSFT temporarily deployed to github-pages October 9, 2023 17:38 — with GitHub Actions Inactive
waelkdouh
waelkdouh approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@waelkdouh waelkdouh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waelkdouh waelkdouh merged commit ea77857 into main Oct 9, 2023
3 checks passed
@waelkdouh waelkdouh temporarily deployed to github-pages October 9, 2023 17:41 — with GitHub Actions Inactive
@simonkurtz-MSFT simonkurtz-MSFT deleted the feature/variable-cleanup branch October 9, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waelkdouh waelkdouh waelkdouh approved these changes

@tjoudeh tjoudeh Awaiting requested review from tjoudeh

@pankajagrawal16 pankajagrawal16 Awaiting requested review from pankajagrawal16

Assignees

@simonkurtz-MSFT simonkurtz-MSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonkurtz-MSFT @waelkdouh