-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Xcode 15 and Swift 5.9 compiler #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little worried about the changed md5s. Have you listened to the output to make sure that the sounds have not changed? I have a feeling this change will not pass the CI tests.
@jwyterlin Do the test changes need to be in this PR? The cassert header part should probably be added, but the test changes would need further review/explanation. |
No, they are not needed for the cassert header part. But when I ran the unit tests, they did not pass. Compilers: Swift 5.5 and 5.6 but this method is available since iOS 8.0 ( Link here ) Would it be possible to update the Xcode version? |
This PR fixes an issue that prevents to build it for Xcode 15.
Because of the new Swift compiler (5.9) it's needed to include cassert header.
Here is the error compiler outputs:
In the build report too: