Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

feat: add setting to select current working directory indicator file #1368

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sqcrh
Copy link

@sqcrh sqcrh commented Sep 8, 2020

Currently the current working directory is determined by the location of .eslintignore by default. I think rational behind this makes sense, but it would be a nice feature to have that configurable. I currently do not use .eslintignore but have my project is in a sub folder. This means linter-eslint selects the project root as the current working directory which breaks webpack import linting on my Vue.js projects.

After searching through a few of issues here, in vue cli, and other projects it looks like this is a fairly common point of confusion and use case. Adding this setting would be a convenient feature and i think a lot of users when they discover the cwd is not what they expect might go searching in settings. It would be nice to have something there to indicate how the cwd is selected.

I added the setting to the uncommon section so it doesn't clutter more frequently used settings. If unspecified (default) it should revert to the original behavior. I thought it would be nice to make the default ".eslintignore" or something to indicate what it does currently, but there are a number of fall backs so I decided to keep it totally decoupled from the current behavior.

@UziTech
Copy link
Member

UziTech commented Oct 24, 2021

@sqcrh can you add a test for this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants