Performance improvement suggestion for 2 userscripts #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During my testing of scripts
favicon_in_urlbar.uc.js
andtab_label_in_urlbar.uc.js
I figured out, thatDOMContentLoaded
,load
andTabOpen
event listeners are not really neccessary for scripts to function. Basically, 99% of cases are covered byTabAttrModified
event listener (if not all) — at least in the current Firefox version I tested (v115).Moreover, by removing
TabOpen
listener and adding a check to react only to selected tabs changes, scripts became significally easier on browser startup. Without these changes they processed whatever many tabs user had automatically restored on browser startup — each sending fewTabOpen
andTabAttrModified
events.I guess, the only downside is —
tab_label_in_urlbar.uc.js
will temporary show url in the label widget for new tabs which are still loading and don't have any label yet.