Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to colpali-engine 0.3.x #21

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Bump to colpali-engine 0.3.x #21

wants to merge 5 commits into from

Conversation

tonywu71
Copy link
Collaborator

Features

  • Bump to restructured colpali-engine 0.3.x
  • Remove the unused utils module
  • Various typing improvements in colpali.py

Tests

  • Bump to colpali-v1.2 in tests
  • Add guardrails and instructions in tests

Checklist

@tonywu71 tonywu71 mentioned this pull request Sep 17, 2024
Closed
3 tasks
@tonywu71 tonywu71 self-assigned this Sep 17, 2024
@tonywu71 tonywu71 force-pushed the bump-to-colpali-engine-0.3.x branch 2 times, most recently from 9bbb6eb to 5065d16 Compare September 17, 2024 12:20
@tonywu71
Copy link
Collaborator Author

@bclavie I've started to clean up tests but I'm a bit unsure about the test_add_to_index one, so I've marked it with skip for now! Otherwise, the other tests are passing! 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bclavie bclavie Awaiting requested review from bclavie

Assignees

@tonywu71 tonywu71

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tonywu71