Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Feature/orientationanimation-zoom-exif-errorhandling-scaling #241

Open
wants to merge 81 commits into
base: develop
Choose a base branch
from
Open

Feature/orientationanimation-zoom-exif-errorhandling-scaling #241

wants to merge 81 commits into from

Conversation

Cyclic
Copy link

@Cyclic Cyclic commented Nov 2, 2017

  • Added better orientation change animation and button layout for orientation changes, added exif and error output, added error handling for cases where exif data is not present after capture, add check that existing capture is not taking place, updated constraints to handle more scenarios when the layout changes, added a scale option to use scale by a factor to output of new photos. Added a few more options for output.

Some known layout issues with the main viewController that should be easy to resolve.

@Cyclic Cyclic changed the title Feature/orientationanimation-zoom-exif-errorhandling Feature/orientationanimation-zoom-exif-errorhandling-scaling Nov 3, 2017
@Cyclic Cyclic changed the title Feature/orientationanimation-zoom-exif-errorhandling-scaling Feature/orientationanimation-zoom-exif-errorhandling-scaling-swift4.0 Nov 3, 2017
@AlexLittlejohn
Copy link
Owner

I'll take a look at this shortly.

@AlexLittlejohn
Copy link
Owner

This is a huge change that introduces a great many dependancies along with other changes. This renders it unusable for most people as the cost of integrating it would then be too high. If you want you can continue to use your fork and possibly submit more isolated changes?

@Cyclic
Copy link
Author

Cyclic commented Nov 8, 2017 via email

@Cyclic Cyclic changed the title Feature/orientationanimation-zoom-exif-errorhandling-scaling-swift4.0 Feature/orientationanimation-zoom-exif-errorhandling-scaling Nov 8, 2017
@Cyclic
Copy link
Author

Cyclic commented Nov 8, 2017

@AlexLittlejohn I reverted back to swift 3.2 for now, there were only a few lines to change. I've also removed all of the cocoapods since they were unnecessary. There is a minor issue on the front screen after the photo is accepted, but it should be pretty straight forward to resolve. The main thing is the linting, the animation on the camera buttons as you rotate the screen (we can make the animation style configurable or you can change it inline), center the close button (lots of feedback about this from users), the additional scale parameter for photo output, and the exif and error data, which help a lot for debugging or logging. The fact that the buttons are pinned on the camera vc, IMO, feels like a more native experience and removes some of the complexity around the constraints.

@Cyclic
Copy link
Author

Cyclic commented Nov 8, 2017

@AlexLittlejohn I should also mention that I am creating a Cordova iOS plugin to wrap the camera, so I was hoping to be able to pull from your repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants