Add source generator to emit supporting attribute types #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sergio0694 Thanks for the help here. I think we need to update to .NET 7 so we can use C# 11. Also, I think the pseudo package is busted. I tried to update it, but the analyzer isn't being chained in as expected. I tried to manually load it in the |
|
I've updated the .NET SDK pulled in from the CI script to be .NET 7 👍 |
Sergio0694
force-pushed
the
user/sergiopedri/roslyn-generator
branch
from
3997e8e
to
79e5e09
Compare
Sergio0694
force-pushed
the
user/sergiopedri/roslyn-generator
branch
from
e1b7eba
to
889f8c4
Compare
AaronRobinsonMSFT
approved these changes
Nov 6, 2023
|
The resulting package from the CI looks good 😄
Question: can't remember, are all .props files in the |
Import new targets file using DNNE.targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #168
Overview
This PR includes a new
dnne-analyzersproject, bundling (for now) a generator that produces the supporting attribute types. The setup is pretty much the same as that used in ComputeSharp, the MVVM Toolkit, and several other generators. We have the generator project, a bundled .targets file that is included in the NuGet package that ensures analyzers are either loaded correctly or otherwise produces useful warnings for users, and then some basic props to build and pack the analyzer.