Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change slipwall scalar BC for BDS to respect the design choice that #166

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Change slipwall scalar BC for BDS to respect the design choice that #166

merged 3 commits into from
Aug 5, 2024

Conversation

cgilet
Copy link
Collaborator

@cgilet cgilet commented Aug 5, 2024

no new extrema get introduced.

@cgilet cgilet requested a review from ajnonaka August 5, 2024 02:05
ajnonaka
ajnonaka reviewed Aug 5, 2024
View reviewed changes
Source/NS_setup.cpp Outdated Show resolved Hide resolved
ajnonaka
ajnonaka approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@ajnonaka ajnonaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. Once I see how the CI tests run I'll merge and update the benchmarks.

@ajnonaka ajnonaka merged commit 37327b3 into AMReX-Fluids:development Aug 5, 2024
16 checks passed
@ruohai0925 ruohai0925 mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajnonaka ajnonaka ajnonaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgilet @ajnonaka