Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diffuse tensor velocity #160

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Improve diffuse tensor velocity #160

merged 4 commits into from
Apr 23, 2024

Conversation

cgilet
Copy link
Collaborator

@cgilet cgilet commented Apr 18, 2024 •
edited
Loading

This makes two changes:

  • when computing the RHS with do_mom_diff==1, multiply U_new by rho_new (rather than rho_old); i.e. use
    rho^(n+1) * Unew = rho^(n+1) * [(rho^n U^n - dt U dot grad U + ...)/rho^(n+1)]
  • pass a better initial guess for the solution to the tensor solver. This can change results up to the tolerance of the viscous solve (default relative tol = 1e-10)

@cgilet
Fix typo
308603c
@cgilet
In the viscous tensor solve, do better for the initial guess given
d4a8d9f 
to the solver
@cgilet
Merge remote-tracking branch 'upstream/development' into fix_diffuse_…
b3d12ab 
…tensor_vel
@cgilet
In diffuse_tensor_velocity, for momenta (rho_flag==3), multiply
e456ccf 
Unew by rho^(n+1) for RHS. i.e. we want
rho^(n+1) * Unew =
    rho^(n+1) * [(rho^n U^n - dt U dot grad U + ...)/rho^(n+1)]
@cgilet cgilet changed the title Improve diffuse tensor velocity initial guess Improve diffuse tensor velocity Apr 22, 2024
@cgilet cgilet requested a review from asalmgren April 22, 2024 16:12
@asalmgren asalmgren merged commit 17cb508 into AMReX-Fluids:development Apr 23, 2024
15 checks passed
@cgilet cgilet deleted the fix_diffuse_tensor_vel branch April 23, 2024 12:38
ruohai0925 added a commit to ruohai0925/IAMR that referenced this pull request Apr 24, 2024
@ruohai0925
Merge pull request #23 from AMReX-Fluids/development
bd46fa3 
Improve diffuse tensor velocity (AMReX-Fluids#160)
ruohai0925 pushed a commit to ruohai0925/IAMR that referenced this pull request Apr 24, 2024
sync with AMReX-Fluids#160
2e09ab0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalmgren asalmgren asalmgren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgilet @asalmgren