Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] clean-up the transverse flux correction #1920

Open
wants to merge 10 commits into
base: development
Choose a base branch
from

Conversation

zingale
Copy link
Member

@zingale zingale commented Jun 25, 2021

PR summary

The transverse flux correction is done to the conserved interface state variables after we do the normal interface prediction. Previously we were doing a transverse correction on p in order to have enough of a thermodynamic state to get back the primitive state after the correction. Now we instead just work with the conserved state and call the EOS at the end to ensure consistency.

As part of this change, we now do the dual energy formulation consistent with how it is done in ctoprim.

This also fixes an issue with the reset of the state if rho < 0 -- we were not resetting the passives in this case.

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale zingale changed the base branch from main to development June 25, 2021 01:33
@zingale
Copy link
Member Author

zingale commented May 11, 2022

this seems to result in a lot of (rho e) resets in the Riemann solver.

@zingale zingale added the hydro label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant