Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #21

Merged
merged 4 commits into from
Oct 15, 2016
Merged

Refactoring #21

merged 4 commits into from
Oct 15, 2016

Conversation

Robiathin
Copy link
Contributor

Mostly just small tweaks and style changes.

The exit codes were tweaked such that 1 is for bad commands, 2 is for situations where something should exist but doesn't, 3 is for situations where something does exist but shouldn't.

Kind of as per #20 but I wouldn't exactly call myself a bash wizard. There is still probably some more that can be done but this is a first pass.

@1egoman
Copy link
Owner

1egoman commented Oct 15, 2016

Nice, thanks for the help!

EDIT: Looks like you're still making commits. Let me know when you're complete, and if it looks good, I'll merge.

@Robiathin
Copy link
Contributor Author

All done now, just noticed one last thing. Glad I could be of use.

@1egoman
Copy link
Owner

1egoman commented Oct 15, 2016

👍

@1egoman 1egoman merged commit c109798 into 1egoman:master Oct 15, 2016
@1egoman 1egoman mentioned this pull request Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants