Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting desired traffic to a non-existing version should fail #36

Open
linki opened this issue Aug 27, 2018 · 0 comments
Open

setting desired traffic to a non-existing version should fail #36

linki opened this issue Aug 27, 2018 · 0 comments

Comments

@linki
Copy link
Member

linki commented Aug 27, 2018

currently I can set traffic on a version that doesn't exist. It will correctly reduce the desired traffic to the existing versions but will not add the new version to the annotation (as it doesn't exist).

The actual traffic is not changed so it doesn't do much harm.

The client should probably fail or at least print something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant