Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "My workouts" and "My exercises" to Gym menu #200

Open
s-edwards opened this issue Aug 31, 2021 · 2 comments
Open

Add "My workouts" and "My exercises" to Gym menu #200

s-edwards opened this issue Aug 31, 2021 · 2 comments

Comments

@s-edwards
Copy link
Member

Since individual users can author workouts and exercises, we should probably add links under "Gym" to access a user's own authored workouts and exercises. If they're public, they're already listed in the gym, but seeing them on a separate page for easy editing would be nice.

Basically, this would be a separate "owner" view for workouts and one for exercises.

If we do this, we probably need to separately group and/or indicate whether the exercises and workouts are public or private, and possibly whether they are associated with a course. Or do we not show course-oriented resources and only show stuff that doesn't fit in a course? Currently, the course home page is intended to provide access to course-specific workouts and course-specific exercises, so maybe these under the gym only provide access to non-course items.

Concerns:

  • We don't want to limit to just public items, since it is possible to have non-public exercises or workouts that are also not course-affiliated, and those need to be accessible somewhere. Even gym-oriented resources might be non-public while they are being developed and are not yet ready for public consumption.
  • If we include course resources, we need to be careful about repeated workouts with the same name cloned across different semesters, since those are separate workout instances.
  • We need to think about whether the "Create New" button should actually be on the personal collection page instead of on the main gym page.
  • We need to think about the author/owner relationships, and how/if we want to separately indicate ownership from author access, or do we want separate visual indications for this on the thumbnails in general (so viewers can tell if they have special privileges on a given exercise or workout based on their owner/author status).
@Ln11211
Copy link

Ln11211 commented Sep 28, 2021

Hello, I want to do this issue, is this issue for a first timer ?

@s-edwards
Copy link
Member Author

These would be good for someone to get started with if they are new to the project. However, even "first timer" issues doe require some rails knowledge/experience, and probably a bit of learning about the data model and the way permissions are implemented through CanCan. But if you're familiar with rails and CanCan and that general background info, this could be a useful way to become familiar with the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants