Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ignite to the latest version #48

Open
sveneberth opened this issue May 28, 2021 · 5 comments
Open

Update ignite to the latest version #48

sveneberth opened this issue May 28, 2021 · 5 comments
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file feature New feature or request

Comments

@sveneberth
Copy link
Member

Although the ignite submodule was updated by #36 to almost the latest version, the corresponding changes were not made.
Some structural changes are necessary and the base needs to initialize the ignite elements.

@sveneberth sveneberth added bug Something isn't working feature New feature or request dependencies Pull requests that update a dependency file labels May 28, 2021
@phorward
Copy link
Member

phorward commented Nov 9, 2021

Is this done by #53 now?

@sveneberth
Copy link
Member Author

Is this done by #53 now?

Nope. The project LESS and HTML must be changes. There're several (breaking) changes. In ignite there is a backward compatibility for the element initialization, but I'm not sure if this works for all changes and should be updated in the future anyway... AFAIK some CSS classes or the structure (HTML) how to nest them were changed and needs to be adjusted (a few changes were also needed in the docs).

@phneutral
Copy link
Member

I'll look at the whole issue (hopefully) over the next week.

@phorward
Copy link
Member

@phneutral @sveneberth bump! Can we merge this with https://github.com/viur-framework/viur-base/tree/rework asap?

@sveneberth
Copy link
Member Author

@phneutral What's the status?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants