Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log configuration coming from system properties, not just rule params #27

Open
seanf opened this issue Oct 29, 2014 · 1 comment
Open

Comments

@seanf
Copy link
Contributor

seanf commented Oct 29, 2014

When a config item like the database URL is modified in the rule configuration, enforcer outputs log information, but when the same config item is configured via a system property, there is no logging.

Worse still, if both values have been set, the database config from the rule is logged, but it is the system property which takes precedence!

By the way, you might find it helpful to integrate the logging for victims-lib-java and victims-enforcer.

zanata-maven-plugin uses com.pyx4j:maven-plugin-log4j plus org.slf4j:slf4j-log4j12to allow generic (non-Maven) code in zanata-client-commands to log to Maven's log system by using slf4j calls.

See https://github.com/zanata/zanata-client/blob/client-3.4.0/zanata-maven-plugin/src/main/java/org/zanata/maven/ConfigurableMojo.java#L106 for the setup code.

@seanf
Copy link
Contributor Author

seanf commented Nov 5, 2014

Regarding the integrated logging, it looks like this library might be a little simpler than combining com.pyx4j:maven-plugin-log4j with org.slf4j:slf4j-log4j12: http://slf4j.jcabi.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant