Update page to 1.11.5 #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-dimitru
reviewed
Apr 3, 2020
| @@ -633,7 +637,7 @@ Tinytest.add('Client - Router - base path - url generation', (test) => { | |||
|
|
|||
| function setBasePath(path) { | |||
| FlowRouter._initialized = false; | |||
| FlowRouter._basePath = path; | |||
| FlowRouter.basePath(path); | |||
There was a problem hiding this comment.
@jankapunkt Wouldn’t it be major changes?
Maybe we can change _basePath to setter instead of function?
dr-dimitru
added a commit
that referenced
this pull request
Jun 8, 2022
|
@jankapunkt do you want to try update |
|
@dr-dimitru does it make sense to continue this one, since Meteor3 upgrade is breaking anyway? |
|
@dr-dimitru also, it looks like page is abandoned and people look for a fork. |
|
@jankapunkt I'll jump on full rewrite sometimes soon, dropping all dependencies. We can close this one for now. Latest release works with meteor@3 as expected, right? |
|
@dr-dimitru it does not support Blaze 3, which is why I commented on #113 to include it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this is a work in progress PR attempting to fix #74 , since there are multiple issues to address. Not all issues may have been detected yet and regression needs to be tested as well.
Currently detected issues:
_basePathis chained infinitelyThis isse is fixed by always transforming the path to a
/namepattern. I am not 100% if thepagepackage now won't accept other path variations as base anymore or has a bug or something._basePathis stripped. afterinitializeis calledThis is fixed by setting the
dispatchoption in thepage(options)call tofalse. This fixes theClient - Router - base pathtests. However, there is no regression-test added yet.We first need to find out, why the exit trigger is fired twice now, while before once