Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent usage of amdWebGlobal #78

Open
App3x opened this issue Feb 10, 2016 · 2 comments
Open

Inconsistent usage of amdWebGlobal #78

App3x opened this issue Feb 10, 2016 · 2 comments

Comments

@App3x
Copy link

App3x commented Feb 10, 2016

https://github.com/umdjs/umd/blob/master/templates/amdWebGlobal.js

What about case when i have amd, but for any architecture reasons i dont use it, but i still want just to include library and get global variable.

More correctly will be:

        define(['b'], function (b) {
               return factory(b);
        });
        root.amdWebGlobal = require('b');

because global variables are for "inline" usages, not for amd approach.

"backward compatibility" of libraries should not be affected by my architecture.

why by adding third party amd it should breaks existing usages of any library?

this is definitely wrong approach.

@ipetropolsky
Copy link

+1

@ipetropolsky
Copy link

Example of real problem: DmitryBaranovskiy/raphael#1026 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants