Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme patching using env parameters #133

Open
realies opened this issue Dec 13, 2021 · 2 comments
Open

Add theme patching using env parameters #133

realies opened this issue Dec 13, 2021 · 2 comments

Comments

@realies
Copy link

realies commented Dec 13, 2021

Since thelounge does not support custom theme-name meta name values, could this be optionally added here via an environment variable? For example, if I'm making all #415364 fields black using Docker post arguments like these at the moment:

bash -c "sed -i 's/415364/000000/' /usr/local/share/.config/yarn/global/node_modules/thelounge/{public/thelounge.webmanifest,client/index.html.tpl} && docker-entrypoint.sh thelounge start"

@williamboman
Copy link
Member

Hello! Hmm not sure I'm following what you mean by custom theme-name meta name values. Do you mean like parameterizing themes, to allow for user overrides?

Is there a broad use case/need for this? Otherwise you could either override the container's entrypoint, or extend the image with your own Dockerfile, with your custom entrypoint:

#!/bin/bash

sed -i 's/415364/000000/' /usr/local/share/.config/yarn/global/node_modules/thelounge/{public/thelounge.webmanifest,client/index.html.tpl}

# The original docker-entrypoint.sh exists on PATH
docker-entrypoint.sh "$@"

@realies
Copy link
Author

realies commented Dec 23, 2021

Yes, I mean customising theme parameters such as the meta theme-name natively by this Docker image. I know that this is currently not possible via thelounge itself, and probably it will be a while until it is. Do you think it's appropriate to have this functionality in here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants