Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language is not taken into consideration when caching / checking the cache #63

Open
dannydorfel opened this issue Nov 3, 2022 · 1 comment

Comments

@dannydorfel
Copy link

In the Client.php, line 605, the cache key is defined by stories/ . $slug and the options are missing. This causes the client to always return the first cached story when requesting other language versions of a story.

@roberto-butti
Copy link
Collaborator

roberto-butti commented Dec 9, 2022

I see. Thank you @dannydorfel .
I see in the code we are also using some "options" that could contribute to defining the key for the cache.
In this case, i would open a PR with and hash (as a suffix of the cache key) calculated on the relevant options.

From the implementation perspective, I think this issue is strongly related to this one: #55 (comment)

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants