Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explorer: token history repeats tx signature #204

Open
ngundotra opened this issue Dec 23, 2022 · 5 comments
Open

explorer: token history repeats tx signature #204

ngundotra opened this issue Dec 23, 2022 · 5 comments

Comments

@ngundotra
Copy link
Collaborator

Example:

https://explorer.solana.com/address/JAVUMWaYbpq8sEtnNUkbbeSRBKHMrBTW5uVQRy5SKoMW/tokens

Context:

https://discord.com/channels/428295358100013066/531947850007969828/1055905404317614202

cc @t-nelson

@nvsriram
Copy link
Contributor

The reason why the tx signatures are repeated (10 times in this case) is because each unique tx signature for the transaction corresponds to 10 Token Program: Mint To instructions. The code extracts the name of the instruction (Mint To) and any inner instructions that exist for each instruction per unique tx signature. So that's why we have 10 rows that look identical but technically correspond to 10 different instructions for every tx signature.
What would be the desired behaviour though?

cc @t-nelson

@t-nelson
Copy link
Contributor

could we collapse them into one entry, similarly to how inner instructions are treated?

Screenshot from 2023-01-17 15-49-29

@nvsriram
Copy link
Contributor

nvsriram commented Jan 18, 2023

We could flat map all the instructions such that every instruction (including inner instructions) corresponds to a separate row with hyperlinks to that specific instruction. This would be consistent with the serial order in which all the instructions are executed. Would this solve the issue?

cc @t-nelson

@t-nelson
Copy link
Contributor

i think it's more important to retain the instruction hierarchy than the links. i don't personally see any value in being able to navigate to a particular instruction from that page. that is, i don't care which instructions touch a token account, just which transactions do.

@nvsriram
Copy link
Contributor

Each transaction with more than one instruction can be expanded as shown in the screenshot. The inner instructions expand as they did before. Would this be consistent to what you had in mind?

image

cc @t-nelson

@ngundotra ngundotra transferred this issue from solana-labs/solana Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@t-nelson @ngundotra @nvsriram and others