Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to generate equals and hashcode for @ConfigMapping #1067

Closed
ia3andy opened this issue Dec 19, 2023 · 4 comments · Fixed by #1181
Closed

Add the ability to generate equals and hashcode for @ConfigMapping #1067

ia3andy opened this issue Dec 19, 2023 · 4 comments · Fixed by #1181
Labels
enhancement New feature or request

Comments

@ia3andy
Copy link

ia3andy commented Dec 19, 2023

Currently, it's possible to generate toString as explained here:
https://smallrye.io/smallrye-config/Main/config/mappings/#tostring

But there is nothing for equals and hashcode.

The use case is for Quarkus extension config, without this, it's very ugly to deal with equals as shown in this PR:
quarkiverse/quarkus-quinoa#594

When this is done we should update the Quarkus writing extension guide to mention this.

@ia3andy
Copy link
Author

ia3andy commented Dec 19, 2023

cc @radcortez

@dmlloyd
Copy link
Contributor

dmlloyd commented Dec 19, 2023

This relates to #1001 since those generated interfaces also need equals/hashCode, and should share as much code as possible.

@radcortez radcortez added the enhancement New feature or request label Jan 16, 2024
@ia3andy
Copy link
Author

ia3andy commented Mar 14, 2024

@radcortez any update on this?

@radcortez
Copy link
Member

Not yet... sorry @ia3andy. Let me try to prioritize this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants