Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace slack-utils with the slack package #71

Open
captn3m0 opened this issue May 26, 2019 · 10 comments
Open

Replace slack-utils with the slack package #71

captn3m0 opened this issue May 26, 2019 · 10 comments
Assignees

Comments

@captn3m0
Copy link
Member

The slack-utils package was written when there weren't many good clients for Slack available. However:

  • Jinora is the only app using it
  • It hasn't been maintained in quite some time
  • There are known security issues with the dependencies it is using

I've been trying to do a new release, but mocha is causing some issues with tests that I don't want to bypass: sdslabs/slack-utils#7

But even then, this would be a stop-gap measure, since slack-utils relies on Slack Legacy Tokens and not the new API. Using the new API would also give Jinora some super-powers like supporting multiple organizations easily with one-click installs.

@vrongmeal
Copy link

vrongmeal commented Jun 7, 2019

Can you post the link to the slack package you're talking about?

@captn3m0
Copy link
Member Author

captn3m0 commented Jun 7, 2019 via email

@vrongmeal
Copy link

Yeah... So I was asking about the package we want to replace slack-utils with.

@captn3m0
Copy link
Member Author

captn3m0 commented Jun 7, 2019

Sorry, was on mobile.

https://www.npmjs.com/package/slack seems to support everything

@vrongmeal
Copy link

Thanks! I'll take a look at it :)

@captn3m0
Copy link
Member Author

@vrongmeal Any update on this?

@vrongmeal
Copy link

Hi! Sorry I've been a bit busy. Totally forgot about this. I'll ask someone else if anyone is interested in changing the dependency.

@captn3m0
Copy link
Member Author

captn3m0 commented Jul 1, 2019

Please do. I'm planning to delete the npm package by month end (31st July)

@captn3m0
Copy link
Member Author

@vrongmeal Is someone picking this up?

@vrongmeal
Copy link

Yeah. @ayanchoudhary has taken this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants