Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inactive storage locations and items to the seed #4526

Open
2 tasks
cielf opened this issue Jul 14, 2024 · 5 comments
Open
2 tasks

Add inactive storage locations and items to the seed #4526

cielf opened this issue Jul 14, 2024 · 5 comments
Assignees

Comments

@cielf
Copy link
Collaborator

cielf commented Jul 14, 2024

Summary

Add inactive storage locations and items to the seed

Why?

Better data for when we are investigating problems and demontrating features to the stakeholders

Details

An inactive storage location may have items associated with it, but the level of those items will be zero.
An inactive item will have no current inventory.

Criteria

  • at least 1 inactive storage location exists in the seed
  • at least 1 inactive item exists in the seed.
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Jul 14, 2024
@awwaiid awwaiid modified the milestone: Tasks 2024 Jul 28, 2024
@aman5438
Copy link

I would like to tackle this one!

@cielf
Copy link
Collaborator Author

cielf commented Jul 30, 2024

It's yours!

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Jul 30, 2024
@aman5438
Copy link

Hello @cielf , Apologies for the delay in progress due to a medical emergency. I would appreciate it if you could clarify further on how we can create a storage location as inactive. I'm a bit confused about this. Thank you for your understanding.

@cielf
Copy link
Collaborator Author

cielf commented Aug 27, 2024

That's a good question. I looked at the code that is called when we press the "deactivate" button on a storage location. From storage_location_deactivate_service.rb, it appears that we call discard! on the storage location to deactivate it.

So, create the storage location and then discard! it?

@aman5438
Copy link

Thank you for the clarification. I understand now. So, after creating a storage location, I would just need to call discard! on it to set it as inactive. I’ll go ahead and implement this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants