Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Support absolute/relative and file/directory types #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Support absolute/relative and file/directory types #80

wants to merge 2 commits into from

Conversation

rofinn
Copy link
Owner

@rofinn rofinn commented Apr 12, 2020 •
edited
Loading

Summary

  • Introduce Form and Kind concepts (though not exported) which paths are parameterized by.
  • Aliases for dispatching (e.g., AbsolutePath, RelativePath, FilePath, DirectoryPath)
  • Stricter parsing based on the above types (e.g., directories must end with a separator)
  • Dropping ispathtype in favour of just tryparse
  • Wrapper methods to return the appropriate types
  • Extra tests for the new parsing approach
  • Update AWSS3.jl
  • Add support to FTPClient.jl?

Closes #72, #78 and #79

@rofinn rofinn changed the title Support absolute/relative and file/directory types WIP: Support absolute/relative and file/directory types Apr 13, 2020
@rofinn
Copy link
Owner Author

rofinn commented Apr 13, 2020

I'm not sure if it's worth continuing to work on this. This approach has some nice properties, but it adds a lot of complexity and hacks that may confuse users coming from the Base.Filesystem API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idea: RelativePath as own type, independent from other details
1 participant
@rofinn