Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to the package #26

Open
gdequeiroz opened this issue Feb 20, 2018 · 4 comments
Open

Add tests to the package #26

gdequeiroz opened this issue Feb 20, 2018 · 4 comments
Assignees

Comments

@gdequeiroz
Copy link
Member

So far we only have 2 tests: test-get_events.R test-find_groups.R.

We need to add tests to other functions (https://github.com/rladies/meetupr/tree/master/R)

@missaugustina
Copy link
Member

missaugustina commented Apr 12, 2018

Also see issue #31 and PR #32

I'm working on tests and if my changes are approved, would like to pair with others who are looking for ways to contribute.

@gdequeiroz
Copy link
Member Author

@missaugustina I changed the label from "help wanted" to " work in progress" since you are working on that. :)

@missaugustina
Copy link
Member

I will add stubs similar to what I did for remaining tests needed for the other ones. This will make it easier for folks to see what tests are needed and to make easy contributions.

@maelle maelle mentioned this issue Jan 8, 2021
@maelle
Copy link
Contributor

maelle commented Jan 8, 2021

I need to add more tests & vcr fixtures. @ledell I wouldn't want us to submit the package to CRAN before we have something like 75% coverage. Should be achievable.

> covr::package_coverage()
meetupr Coverage: 28.47%
R/deprecated.R: 0.00%
R/get_boards.R: 0.00%
R/get_event_attendees.R: 0.00%
R/get_event_comments.R: 0.00%
R/get_event_rsvps.R: 0.00%
R/get_members.R: 0.00%
R/uq-filename.R: 0.00%
R/utils-renv.R: 0.00%
R/zzz.R: 8.33%
R/meetup_auth.R: 14.88%
R/internals.R: 53.12%
R/find_groups.R: 94.12%
R/get_events.R: 100.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants