Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code Warning Underline won't go away if initial run fails #8

Open
sevenfields-matt opened this issue May 17, 2021 · 1 comment
Open
Labels
bug Something isn't working

Comments

@sevenfields-matt
Copy link

image

After an initial run failed the rest of session showed a typehole warning underline. The warning was persistent through opening and closing the file. The warning did go away by restarting VS Code.

Repro:

  1. Run where initial run fails (err that is caught), or possible if the response is accidentally a promise(I initially put it around the call not the awaited version)
  2. Continue and successfully generate an interface for the call
  3. Notice typehole warning underline continues to persist for the session.
@rikukissa rikukissa added the bug Something isn't working label May 18, 2021
@rikukissa
Copy link
Owner

Interesting, the warnings should clear on save. I wonder if, after that, your runtime had time to send one more warning to the editor, which added the warning back. I'll add some code to clear the warnings state when a file closes. Hopefully, that's enough of a fix for now even though it doesn't really fix the exact situation in your image. If you have ideas on how this could be solved better, please let me know.

Thanks for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants