Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherited config should be resolved before merging #31278

Open
rarkins opened this issue Sep 9, 2024 · 0 comments
Open

Inherited config should be resolved before merging #31278

rarkins opened this issue Sep 9, 2024 · 0 comments
Assignees
Labels
breaking Breaking change, requires major version bump core:config Related to config capabilities and presets priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality
Milestone

Comments

@rarkins
Copy link
Collaborator

rarkins commented Sep 9, 2024

Describe the proposed change(s).

Discussion: #31182

To address this:

  • We should resolve presets in inherited config prior to merging the config in
  • We should log a debug message saying we're doing this
  • We should document this behavior clearly, including noting that it's not possible to use an ignorePresets entry to ignore a preset in the extends of inherited config
@rarkins rarkins added type:bug Bug fix of existing functionality priority-2-high Bugs impacting wide number of users or very important features core:config Related to config capabilities and presets labels Sep 9, 2024
@viceice viceice added the breaking Breaking change, requires major version bump label Sep 10, 2024
@viceice viceice added this to the v39 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change, requires major version bump core:config Related to config capabilities and presets priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants