Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceVcl property activate seems not to be working #257

Open
piclemx opened this issue May 10, 2023 · 3 comments
Open

ServiceVcl property activate seems not to be working #257

piclemx opened this issue May 10, 2023 · 3 comments
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@piclemx
Copy link

piclemx commented May 10, 2023

What happened?

We were migrating our service from terraform to pulumi. We decided to put the settings to false to validate the generation of the configuration of the pulumi provider inside fastly. For some reason, the configuration was activated.

Expected Behavior

It should have created the new configuration without activating the new version.

Steps to reproduce

1- Import Fastly service vcl by ID
2- pulumi up with activate: false

Output of pulumi about

CLI
Version      3.51.1
Go Version   go1.19.4
Go Compiler  gc

Plugins
NAME    VERSION
fastly  7.3.1
nodejs  unknown

Host
OS       darwin
Version  12.4
Arch     arm64

This project is written in nodejs: executable='/Users/Alexandre.Lemieux/.asdf/shims/node' version='v20.0.0'

Dependencies:
NAME            VERSION
@pulumi/pulumi  3.66.0
@types/node     16.18.25
zod             3.21.4
@pulumi/fastly  7.3.1

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@piclemx piclemx added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels May 10, 2023
@guineveresaenger
Copy link
Contributor

Hi @piclemx - thanks for opening an issue.

To help us understand what is happening here, can you give us a minimal reproduction of what you're seeing, including how you're importing these resources?

Also, can you explain a bit more what you mean by

configuration of the pulumi provider inside fastly

Thank you so much!

@guineveresaenger guineveresaenger added awaiting-feedback Blocked on input from the author and removed needs-triage Needs attention from the triage team labels May 10, 2023
@piclemx
Copy link
Author

piclemx commented May 10, 2023

Sure @guineveresaenger,

I did import it using pulumi import fastly:index/serviceVcl:ServiceVcl resourceName serviceID.

After that, I ran

pulumi preview inside our pipeline

$ pulumi preview $PULUMI_OPTS $PULUMI_PREVIEW_OPTS
Previewing update (prod):
    pulumi:pulumi:Stack fastly-prod running 
@ previewing update....
.
 ~  fastly:index:ServiceVcl xxx update [diff: +activate,forceDestroy~versionComment]
    pulumi:pulumi:Stack fastly-prod  
Resources:

and after

$ pulumi up --yes $PULUMI_OPTS $PULUMI_DEPLOY_OPTS
Updating (prod):
    pulumi:pulumi:Stack fastly-prod running 
@ updating....
.
 ~  fastly:index:ServiceVcl xxx updating (0s) [diff: +activate,forceDestroy~versionComment]
@ updating....
 ~  fastly:index:ServiceVcl xxx updated (1s) [diff: +activate,forceDestroy~versionComment]
    pulumi:pulumi:Stack fastly-prod  
Resources:
    ~ 1 updated
    1 unchanged
Duration: 4s

The activate created a draft configuration inside Fastly. We need to activate it manually using the Fastly console. In that case, I was expecting to go to the fastly website and see that my config was created, and it was in "draft", but it wasn't.

@guineveresaenger
Copy link
Contributor

To verify,

  1. you imported an existing serviceVcl
  2. you updated the pulumi code to set activate:false
  3. you ran pulumi up on the imported code
  4. rather than a draft config, which you expected, a fully valid(activated?) config was created.

It appears that there are some long standing API mappings issues with this provider, especially on serviceVcl and it would seem this may be on instance of that.

@mikhailshilkov mikhailshilkov removed the awaiting-feedback Blocked on input from the author label Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

3 participants