Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

position: Static header make the tips shifted #90

Closed
sandroden opened this issue Oct 12, 2019 · 8 comments
Closed

position: Static header make the tips shifted #90

sandroden opened this issue Oct 12, 2019 · 8 comments

Comments

@sandroden
Copy link

I'm using quasar with a fixed header. I read other issues that suggested that that's a problem but I have not understood if there's a solution. If needed I can create a codesandbox.io to show the result.

Thanks in advance

@mmorainville
Copy link
Member

Hi @sandroden,

In which case is it a problem? A codesandbox could indeed help.
If it's because of the z-index you can try to increase it.

@sandroden
Copy link
Author

Sorry @mmorainville for not being clear in my post.
I'm talking about (dis)placement of tooltip in the sidebar
Here you can find a complete codesandbox example that is really much worse than what I have in my setup...
If youre not familiar with Quasar setup, let me point out that you won't find a main.js and inizialization is made within boot/vue-tour.js declared in quasar.conf.js.
In my real setup I have a vertical shift (that I corrected cheating with the target) while here I also see a horizontal shift.

@Sweetyy
Copy link

Sweetyy commented Dec 3, 2019

Same problem for me with Quasar and fixed elements in the top navbar.

@louisameline
Copy link

Same issue. Basically, vue-tour scrolls down to put the target at the top of the window. Unfortunately, there is a header there. We should be able to specify some vertical offset that would be taken into account for scrolling.

image

@mreall
Copy link

mreall commented Apr 22, 2020

I have a similar problem, although I'm not using Quasar. I have a fixed header that stays at the top of the page when the user scrolls. vue-tour is offset from where the actual element is.
offset-tour

@mreall
Copy link

mreall commented Apr 22, 2020

I did a quick experiment and it looks like this issue would be fixed by upgrading to popper 2. The upgrade doesn't seem to be very invasive, either.

@HZooly
Copy link
Member

HZooly commented Apr 22, 2020

Thanks for your analysis. Unfortunately, we're not going to upgrade Popper version in the current major Vue Tour version: there are some breaking changes between Popper and Popper 2, we don't want to introduce breaking changes in Vue Tour 1.x.

See proposals here : #103

@mmorainville
Copy link
Member

Hi,

Vue Tour v2.x is out and now uses Popper v2.x so this should fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants