Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track author Orcid verification request state in FieldOrcid component #10389

Closed
ewhanson opened this issue Sep 11, 2024 · 5 comments
Closed

Track author Orcid verification request state in FieldOrcid component #10389

ewhanson opened this issue Sep 11, 2024 · 5 comments
Assignees
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Milestone

Comments

@ewhanson
Copy link
Collaborator

Describe the issue

This issue concerns the ORCID verification functionality for authors within the contributor workflow. Currently, there is a button to trigger an email to request authors verify their ORCID. This button is part of a Vue component that currently tracks the state of the action locally. This means if you send a request to an author, you will see that the request has been sent, but if you reopen the contributor form, the request button state will be set back to its default. This state should be tracked to provide additional information to authors/editors.

Describe the solution

This local state should be moved to the author settings table to track across page refreshes as something like a boolean orcidVerificationSent, which will need to be added to author.json in order to save the value to the author_settings table.

The Vue component should track this value and conditionally display the FieldOrcid component in its "verification sent" state as long as the request has been sent once. (The ability to resend the request once it has been sent already is being handled separately, see: #10319).

This value should be set to true when the request is sent and removed from the database once the ORCID has been verified.

This is currently only needed as part of the author/contributor workflow for sending ORCID verification requests as users are able to do so directly from within OJS without needing an email to be sent.

@ewhanson ewhanson added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Sep 11, 2024
@ewhanson ewhanson added this to the 3.5 Internal milestone Sep 11, 2024
@ewhanson ewhanson assigned ewhanson and taslangraham and unassigned ewhanson Sep 11, 2024
@ewhanson
Copy link
Collaborator Author

@taslangraham, would you mind having a look at this one? Let me know if you need any further details beyond the description above. Thanks!

@taslangraham
Copy link
Contributor

@ewhanson Yes, I'll look into it.

@taslangraham
Copy link
Contributor

Ready for review @ewhanson

PRs

pkp-lib - #10407
UI-library - pkp/ui-library#409

Submodule updates
ojs - pkp/ojs#4439
ops - pkp/ops#771
omp - pkp/omp#1697

@ewhanson
Copy link
Collaborator Author

Hey @taslangraham, one minor comment, otherwise looks good. After you make the change, feel free to merge.

taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Sep 20, 2024
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Sep 20, 2024
taslangraham added a commit to taslangraham/ui-library that referenced this issue Sep 20, 2024
taslangraham added a commit that referenced this issue Sep 20, 2024
#10389 Track author Orcid verification request state
taslangraham added a commit to pkp/ui-library that referenced this issue Sep 20, 2024
pkp/pkp-lib#10389 track author Orcid verification request state
@taslangraham
Copy link
Contributor

All merged! Thanks for the review @ewhanson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Projects
Development

No branches or pull requests

2 participants