Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateLife error not trapped in portal #339

Open
arlin opened this issue Sep 6, 2018 · 6 comments
Open

DateLife error not trapped in portal #339

arlin opened this issue Sep 6, 2018 · 6 comments
Assignees

Comments

@arlin
Copy link
Member

arlin commented Sep 6, 2018

See #335 for examples of lists that give large trees of about 500 tips. In both cases we get an error from DateLife below.

Detect this error and provide an informative error message to the user.

screen shot 2018-09-05 at 8 14 50 pm

@ducvan0212
Copy link
Collaborator

@LunaSare what should I display in portal? Can you provide an understandable message so I will put it in the portal?

@ducvan0212
Copy link
Collaborator

ducvan0212 commented Sep 6, 2018

{"message": "Error: 'results'"}

This is what I got from DateLife scaling service for Brian's sample tree in #335 .

@LunaSare
Copy link
Member

For the first error, something like "There is not enough information to scale this tree with DateLife"
Let me check what's generating the second error...

@ducvan0212
Copy link
Collaborator

@LunaSare

@LunaSare
Copy link
Member

I'm sorry @ducvan0212, it took my a long time to debug this one. But we found the source of error. It should be working now.

Answering your original question, the most common case in which we're not gonna be able to obtain a chronogram with median or sdm is:
"There is not enough time information in databases to get a summary chronogram for this set of taxa."
However, this is a long message and there could be other types of errors. So I think the best option will be to put a more general and short message, to simply indicate that these trees are not available, such as "Unavailable", or simply gray out those options any time DateLife throws an error.

What do you think @bomeara?

@ducvan0212
Copy link
Collaborator

ducvan0212 commented Nov 29, 2018

Anyway, I made the message display as a tooltip. You can check it out from dev server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants