You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bug description
The new "Choose class" dialog implemented in ClyFindClassCommand does not do exact matches, and there is no way to tell that I want to search using exact matches.
For instance, If I write "Object" I want "Object" and not "CmObject" :)
To Reproduce
See the following video:
2024-09-19.23-43-43.mp4
Expected development cost
There is already an implementation of multiple types of matching in the NewFinder. It could be refactored in a new package to be used in the Choose class window. That would need a PR in NewTools so it can include the refactored package.
The text was updated successfully, but these errors were encountered:
I agree with wanting to get the class Object and not the class CmObject when looking for “Object”. But in the demo in NewTools pull request #845 it seems you would still need to select the ‘exact’ option for that. Whereas in Pharo 12 there’s no need for an extra click: you get Object when you type “Object” and just press the return key. A problem in Pharo 12 though is that it’s not always clear whether there’s an exact match or not: issue #13720. That could be solved by scrolling the list to the exact match when there is one, or by putting it first in the list. The ‘ok’ button should probably also be disabled when no class is selected.
I agree with wanting to get the class Object and not the class CmObject when looking for “Object”. But in the demo in NewTools pull request #845 it seems you would still need to select the ‘exact’ option for that. Whereas in Pharo 12 there’s no need for an extra click: you get Object when you type “Object” and just press the return key. A problem in Pharo 12 though is that it’s not always clear whether there’s an exact match or not: issue #13720. That could be solved by scrolling the list to the exact match when there is one, or by putting it first in the list. The ‘ok’ button should probably also be disabled when no class is selected.
Thanks for the feedback. I will try to implement your suggestions in another PR
Bug description
The new "Choose class" dialog implemented in
ClyFindClassCommand
does not do exact matches, and there is no way to tell that I want to search using exact matches.For instance, If I write "Object" I want "Object" and not "CmObject" :)
To Reproduce
See the following video:
2024-09-19.23-43-43.mp4
Expected development cost
There is already an implementation of multiple types of matching in the NewFinder. It could be refactored in a new package to be used in the Choose class window. That would need a PR in NewTools so it can include the refactored package.
The text was updated successfully, but these errors were encountered: