Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests in TKTRawProcessHolderTest + Pharo 9 #111

Open
tinchodias opened this issue May 20, 2021 · 3 comments
Open

Fix failing tests in TKTRawProcessHolderTest + Pharo 9 #111

tinchodias opened this issue May 20, 2021 · 3 comments

Comments

@tinchodias
Copy link
Contributor

tinchodias commented May 20, 2021 •
edited
Loading

Tests: testStackContainsContextsOfMaster and testStackStartingAt.

After debugging a bit, I think it's the same root. A context is expected to head the stack but it isn't (identity equals is false). No idea.
@tinchodias
Copy link
Contributor Author

In fact, these tests are part of TaskItDebugger, and it is broken since Pharo 9 since it depends on GTDebugger.
Time passed and I think we should remove this package from the default group, and open an issue to recover it.

@tinchodias
Copy link
Contributor Author

Related issue: #109

tinchodias added a commit that referenced this issue Apr 13, 2022
@tinchodias
Make TaskItDebugger loadable + mark 2 failing tests as expected
6961207 
See:
#109
#111
@tinchodias
Copy link
Contributor Author

In 6961207, I marked both tests as expected failures and I plan to let this issue open to remind they need attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tinchodias