Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case TaTalentSlotsTests fails (with 2 errors) #9

Open
jvalteren opened this issue Oct 6, 2021 · 2 comments
Open

Test case TaTalentSlotsTests fails (with 2 errors) #9

jvalteren opened this issue Oct 6, 2021 · 2 comments

Comments

@jvalteren
Copy link

jvalteren commented Oct 6, 2021

(Applies to Pharo 8.0)

See TaTalentSlotsTests>>#testRenameKeepingOrderSlot and TaTalentSlotsTests>>#testRenameSlot.

Error message: Instance of TaCompositionElement did not understand #'@@'

See method source for TaAbstractComposition>>#'>>':

>> anAssociation

	^ self @@ { anAssociation }

Binary method #'@@' is not implemented. Looking at the source, it seems that the 'rename slot' behavior is required here.

However, the class TaRenameSlot seems to be incomplete. It should implement method TaRenameSlot>>#traitCompositionExpression.

This seems to be resolved in Pharo 9.0. How can we backport this to Pharo 8.0?

@jvalteren
Copy link
Author

Hi @tesonep, forgot to mention that I like the work you did on Talents :-)

I've created an extension package specifically for Pharo 8.0, which loads conditionally with some BaselineOf magic. I've backported the required code from Pharo 9.0 to make this work. If you're interested, I'll create a pull request. OK?

@jvalteren
Copy link
Author

I just went ahead and added the pull request ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant