Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Artefact-Seaside - PDFDownloadComponent issues, Class not found, and an avoidable MDL dependency #55

Open
sanjayminni opened this issue Oct 1, 2023 · 0 comments
Open

Artefact-Seaside - PDFDownloadComponent issues, Class not found, and an avoidable MDL dependency #55

sanjayminni opened this issue Oct 1, 2023 · 0 comments

Comments

@sanjayminni
Copy link

sanjayminni commented Oct 1, 2023 •
edited
Loading

Purpose / usage of the package Artefact-seaside (not usable) can be made clearer.

  1. downloadPdf refers a class RWBinaryOrTextStream which is not found / undeclared , to be modified to a more current stream class

  2. renderContentOn: html mdlButton requires materialDesignLite - this can be just changed to html button and overall mdl dependency removed which seems to be just for this.

  3. renderContentOn: method french: seems to implemented and the purpose of whole line including translate: is not clear.

BaselineOfArtefact can also be changed to remove loading of materialdesignlite and heimdall which do not seem to be really required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sanjayminni