Memory Leak in vectorStores.fileBatches.uploadAndPoll

[mezozawahra]

Confirm this is a Node library issue and not an underlying OpenAI API issue

• This is an issue with the Node library

Describe the bug

I use S3 Bucket to getObject as stream and then upload it to a vector store using vectorStores.fileBatches.uploadAndPoll, the memory usage is supposed to increase during the upload process and return to its baseline after finishing but it doesn't, I uploaded a 22mb file and memory usage went from 300mb to 360mb and never returned to baseline
Note - 1: the upload process is part of POST request in Express.js, and memory usage remained high even after returning the json response
Note - 2 I tried saving the file to disk using "fs", it consumed memory and returned back to baseline, so I think the bug is in OpenAI SDK

To Reproduce

• this is the ExpressJS request handler, and req.params.id is the the file key saved in s3 bucket
• the file is uploaded successfully to OpenAI

import OpenAI, { toFile } from "openai";
import { S3Client, GetObjectCommand } from "@aws-sdk/client-s3";
import "dotenv/config";

export async function post(req:Request , res: Response, next: NextFunction){
    try {

        let client = new S3Client({
            forcePathStyle: true,
            credentials: {
                accessKeyId: process.env.S3_ACCESS_KEY_ID!,
                secretAccessKey: process.env.S3_SECRET_ACCESS_KEY!,
            },
            endpoint: process.env.S3_ENDPOINT!,
            region: "us-east-1"
        })

        const params = {
            Bucket: "first-bucket",
            Key: req.params.id,
        }

        const command = new GetObjectCommand( params );
        const response = await client.send( command );
        
        const openai = new OpenAI({
            apiKey: process.env['OPENAI_API_KEY'],
        });

        await openai.beta.vectorStores.fileBatches.uploadAndPoll(<insert vector store ID here>, { files: [await toFile(response.Body!, req.params.id)]})
        
        return res.json({success: true})
    } catch(error){
        next(error)
    }
}

import { post } from "./controller/files"
router.get("/:id", post)

Code snippets

No response

OS

Windows 11

Node version

v19.8.1

Library version

4.56.0

[RobertCraigie]

Thanks for the report, could you try again with the latest SDK version? We recently fixed a separate bug with file uploads so this might've been fixed as well

[mezozawahra]

@RobertCraigie I tried the latest version (^4.58.1), the memory consumption is reduced, instead of using 60mb it used 44mb, I tried POST request twice on ExpressJS twice ( uploadAndPoll twice ), so the webapp memory usage reached 390mb and stayed on that level

update I tried it again , here's a before and after upload memory usage
Before

After

[RobertCraigie]

Thanks, we'll investigate.