Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an InferNoLogic Context from Variables Component tab #3597

Open
CharString opened this issue Nov 10, 2023 · 1 comment
Open

Create an InferNoLogic Context from Variables Component tab #3597

CharString opened this issue Nov 10, 2023 · 1 comment
Assignees

Comments

@CharString
Copy link
Contributor

CharString commented Nov 10, 2023

The Variables/Component tab contains KEY and DATA TYPE.
This can be used to create a Context for inference:

Passing an example value is enough for InferNoLogic.

{
  "voornaam": "",
  "iban": "",
  "nettoBedragAOQ": 0,
  "werkgevers": [{"nettoLoon": 0, "periodeNettoLoon": "week"}],
  "uitkeringen": {
    "ww": false,
    "anw": false,
    "aow": false,
    "nee": false,
    "wao": false,
    "wia": false,
    "wajong": false,
    "bijstand": false,
    "ziektewet": false
  }
}

This would catch #2941 if the Designer would "correct" the expression to

{"map": [{"var": "iban"}, [{"var": ""}, {"cat": ["Iban: ", {"var": ""}]}]]}

It would infer that "iban" should be an Array, but from the context it follows that it's a String.

So update the calls to infer from #3596 to use this context.

@CharString CharString self-assigned this Nov 10, 2023
@joeribekker joeribekker added this to the Release 2.5.0 milestone Nov 13, 2023
CharString added a commit to open-formulieren/formio-builder that referenced this issue Nov 28, 2023
CharString added a commit to open-formulieren/formio-builder that referenced this issue Dec 5, 2023
CharString added a commit to open-formulieren/formio-builder that referenced this issue Dec 5, 2023
- Storybook 8 doesn't add implicit fn() on actions anymore
- Add missinng component type type annotations
CharString added a commit to open-formulieren/formio-builder that referenced this issue Dec 5, 2023
- Storybook 8 doesn't add implicit fn() on actions anymore
- Add missinng component type type annotations
CharString added a commit to open-formulieren/formio-builder that referenced this issue Dec 6, 2023
CharString added a commit to open-formulieren/formio-builder that referenced this issue Dec 6, 2023
- Storybook 8 doesn't add implicit fn() on actions anymore
- Add missinng component type type annotations
CharString added a commit to open-formulieren/formio-builder that referenced this issue Dec 6, 2023
CharString added a commit to open-formulieren/formio-builder that referenced this issue Dec 6, 2023
It still lags a bit, but it's close to on change. Small edits aren't
detected immediately.
@CharString CharString linked a pull request Dec 6, 2023 that will close this issue
CharString added a commit to open-formulieren/formio-builder that referenced this issue Dec 6, 2023
It still lags a bit, but it's close to on change. Small edits aren't
detected immediately.
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Dec 22, 2023
Viicos pushed a commit to open-formulieren/formio-builder that referenced this issue Dec 22, 2023
Viicos pushed a commit to open-formulieren/formio-builder that referenced this issue Dec 22, 2023
- Storybook 8 doesn't add implicit fn() on actions anymore
- Add missinng component type type annotations
Viicos pushed a commit to open-formulieren/formio-builder that referenced this issue Dec 22, 2023
Viicos pushed a commit to open-formulieren/formio-builder that referenced this issue Dec 22, 2023
It still lags a bit, but it's close to on change. Small edits aren't
detected immediately.
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Dec 22, 2023
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Dec 22, 2023
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Dec 22, 2023
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Dec 22, 2023
I'm not surprised anymore by this kind of things....
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Dec 27, 2023
Viicos pushed a commit to open-formulieren/formio-builder that referenced this issue Dec 27, 2023
Viicos pushed a commit to open-formulieren/formio-builder that referenced this issue Dec 27, 2023
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Dec 27, 2023
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Dec 27, 2023
Viicos pushed a commit to open-formulieren/formio-builder that referenced this issue Dec 27, 2023
Viicos pushed a commit to open-formulieren/formio-builder that referenced this issue Dec 27, 2023
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Dec 27, 2023
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Dec 27, 2023
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Dec 27, 2023
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Dec 27, 2023
@joeribekker joeribekker removed this from the Release 2.5.0 milestone Jan 12, 2024
@joeribekker
Copy link
Contributor

Type inference feature was cancelled due to implementation difficulties vs benefits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants