Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main branch is not default #175

Open
Tracked by #286
zakkg3 opened this issue Feb 1, 2024 · 8 comments
Open
Tracked by #286

Main branch is not default #175

zakkg3 opened this issue Feb 1, 2024 · 8 comments
Assignees
Labels
bug Something isn't working pending Issue is in a branch waiting for a release
Milestone

Comments

@zakkg3
Copy link

zakkg3 commented Feb 1, 2024

dismiss this and read the next comment.

Values files specify the need for keys on the existingSecret, but "napalm_password" is not there and the pod does not start if this is missing.

  Warning  FailedMount             85s (x2 over 3m27s)   kubelet                  MountVolume.SetUp failed for volume "secrets" : references non-existent secret key: napalm_password

@zakkg3
Copy link
Author

zakkg3 commented Feb 1, 2024

I found the problem is that the default branch here is not main and you land by default on dev branch so the 5.0.0 chart which is not published.

The latest we can use is 4.1.1 and this is on main branch, wich is not the main one. o,0

very confusing, And I am pretty sure I am not the first one misled by this.

I guess the most sane would be to set main as the default branch and all this will be solved, like in every single reasonable repo

@zakkg3 zakkg3 changed the title napalm_password required on existingSecret not documented on values files. Main branch is not default o,0 Feb 1, 2024
@tpzumezawa
Copy link

Happened to us :(

@bootc
Copy link
Member

bootc commented Feb 3, 2024

Yeah I could do that, but it's a double-edged sword. People contributing PRs would target the wrong branch and end up with wasted work/time fixing things that are already fixed, or having to redo their changes because what they're targeting has changed. GitHub unfortunately makes this very difficult.

@LeoColomb
Copy link
Member

Based on the new release workflow, I think it is fine to drop the master branch and rename develop to main.
The complete history is still part of the main branch, and the tags keep the stable git HEAD available.
What do you think @netbox-community/netbox-chart-maintainers?

@LeoColomb LeoColomb changed the title Main branch is not default o,0 Main branch is not default Jun 13, 2024
@RangerRick
Copy link
Contributor

Based on the new release workflow, I think it is fine to drop the master branch and rename develop to main. The complete history is still part of the main branch, and the tags keep the stable git HEAD available. What do you think @netbox-community/netbox-chart-maintainers?

Yeah, makes sense to just use once since we've got a just-in-time thing going now. That said, maybe it makes sense to merge develop over to main, and get rid of develop? It would signal better how the current workflow is, IMHO.

@LeoColomb
Copy link
Member

I believe that is the same, with a merge step in addition 😅 (there is no main at the moment)

@RangerRick
Copy link
Contributor

Oops I meant master in this case, not main.

@RangerRick RangerRick self-assigned this Jul 22, 2024
@RangerRick RangerRick added bug Something isn't working pending Issue is in a branch waiting for a release labels Jul 22, 2024
@RangerRick
Copy link
Contributor

Since we've moved to a more dynamic workflow in general (single branch for release -- currently develop -- and then everything comes from PRs) I will fix this when 5.0.0 rolls out for real.

@RangerRick RangerRick added this to the 5.0.0 milestone Jul 22, 2024
@LeoColomb LeoColomb modified the milestones: 5.0.0, 5.0 bugfixes Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending Issue is in a branch waiting for a release
Projects
None yet
Development

No branches or pull requests

5 participants