RUST-2030 Add more event fields: lsid, txnNumber and disambiguatedPaths #1197
Conversation
arthurprs
force-pushed
the
more-event-fields
branch
from
edaebe6
to
af8b927
Compare
| lsid: Some(lsid), | ||
| txn_number: Some(1), | ||
| .. | ||
| }) if key == doc! { "_id": 1 } && lsid.get("id") == session_id.as_ref() |
There was a problem hiding this comment.
The lsid contains a second field "uid", which I'm not familiar with. But the test should still be valid.
|
Hey @arthurprs, thanks for opening this PR! We have an open ticket for adding the What is your use case for adding the |
|
Maybe I'm misinterpreting the manual page but Our use cases includes detecting if a certain actor was the source of the write by its session ID (or previous ones). |
|
You're quite right, those fields are in the manual! The confusing part here on our end is that they're not part of the specification, so I'm working to track down that discrepancy. My concern is that I don't want to add fields to the public API if they're not actually intended to be part of the stable interface 🙂 While we're tracking this down, you should be able to unblock anything that needs those fields by defining your own event type and using it with |
abr-egn
changed the title
|
Sorry for the delay here, it looks like it was just a simple oversight that those fields weren't included in the spec. I've started the test run and assuming there are no unexpected failures I'll merge this in. Thanks again for your patience! |
|
It looks like the test is using some logic that's not supported in server version 4.x, can you add a check to restrict it to >=5.0? |
|
Done in bba9d00 |
Add more event fields: lsid, txnNumber and disambiguatedPaths