Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting moduleResolution to bundler causes red squiggles #1620

Open
Tracked by #1913 ...
neilenns opened this issue Jul 10, 2023 · 10 comments
Open
Tracked by #1913 ...

Setting moduleResolution to bundler causes red squiggles #1620

neilenns opened this issue Jul 10, 2023 · 10 comments
Labels
bug Something isn't working tracked

Comments

@neilenns
Copy link

Environment (please complete the following information):

  • OS (e.g., Windows 10): Windows 11
  • Extension version (e.g., 1.2.3): v2.1.2

Describe the bug:

The extension causes red squiggles when moduleResolution is set to bundler in tsconfig.json.

Repro steps:

  1. Create a new React Typescript project using Vite: npm create vite@latest my-react-app --template react-ts
  2. Open the generated tsconfig.json

Expected behavior:

No red squiggles. bundler is a valid module resolution type as of Typescript 5.

Additional context:

Disabling the extension makes the red squiggles go away.

@captainbrosset captainbrosset added bug Something isn't working tracked labels Jul 11, 2023
@captainbrosset
Copy link
Collaborator

Thanks for filing this. Tracking this on the team's backlog.

@CrossScarDev
Copy link

When will this be fixed? Been bugging for months.

@captainbrosset
Copy link
Collaborator

Apologies for this. Unfortunately, we have no timeline to share for this specific issue.

@bmc1995
Copy link

bmc1995 commented Nov 9, 2023

I think this has something to do with Webhint.

Disabling vscode-edge-devtools: Webhint works for me.

@mpotane
Copy link

mpotane commented Nov 10, 2023

I think this has something to do with Webhint.

Disabling vscode-edge-devtools: Webhint works for me.

No don't do this it is built in edge.

@John-Dennehy
Copy link

This issue may seem small but I legitimately considered uninstalling Edge Tools entirely over it. How hard can it be to Add 'Bundler' to a list of valid options?!

@CallMeLaNN
Copy link

Same

This issue may seem small but I legitimately considered uninstalling Edge Tools entirely over it. How hard can it be to Add 'Bundler' to a list of valid options?!

I use Edge quite some time due to the marketing and effort to make it as better tool for end user than just a browser. I just have this ext recommended and tried in a basic new web project that I working on.

I'm not sure how helpful this ext is, it can't relate with .tsx file anyway, but this ext "helps" me by giving this error from outdated ts config check. Webhint project doesn't seems active and the ts config schema latest update was last year.

References:
webhintio/hint/blob/main/packages/parser-typescript-config/src/schema.json
webhintio/hint/issues/5719

@oddiz
Copy link

oddiz commented Dec 18, 2023

Firstly, thanks for putting option to disable the webhint in VS Code settings. You can disable it to get rid of the errors.
image

Secondly, I'm wondering why an outdated linter is enabled by default in the extension, or why it's included at all. Many of us already use our own linters with settings that we prefer for our projects. It's annoying to have an extra one pop up from a debugging extension.

I think it would be better to remove webhint, or at least have the extension check if there's already a linter set up in the workspace. This way, new developers can still be introduced to the concept, which I assume why it is included in the first place.

@mohamed2015ali mohamed2015ali mentioned this issue Dec 19, 2023
@sijso sijso mentioned this issue Dec 20, 2023
@ShravanSunder
Copy link

still a issue in 2023. Its a bit confusing why this extension's linting would precedence over project linting rules in tsconfg.

@ElormCoch
Copy link
Contributor

Thanks for reporting this. We're working on updating webhint with a fix. In the mean time as a workaround, you can disable a specific rule by using a .hintrc file without disabling webhint altogether.

You can check the documentation on hintrc file here:
Hints | webhint documentation
and you can read about the specific rules that need to be disabled in here:
Valid TypeScript configuration | webhint documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tracked
Projects
None yet
Development

No branches or pull requests

10 participants