Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic ECDSA - RFC6979 #441

Open
karel-m opened this issue Oct 3, 2018 · 11 comments
Open

Deterministic ECDSA - RFC6979 #441

karel-m opened this issue Oct 3, 2018 · 11 comments

Comments

@karel-m
Copy link
Member

karel-m commented Oct 3, 2018

It would be nice to support deterministic ecc signatures - see https://tools.ietf.org/html/rfc6979

It is related only to ecc_sign_hash_ex as the verification works as usual.

It can be done without any API change, simply when prng parametr of ecc_sign_hash_ex is passed NULL then we will not throw an error but create the deterministic signature as described in RFC6979.

Any takers?

Cc: @rmw42 - what do you think? IMO you have pretty impressive ECDSA-related traction during last few weeks 😄

@rmw42
Copy link
Contributor

rmw42 commented Oct 3, 2018

Yeah, it'd be a useful feature to support. If it can wait a week or two, I can find some time to work on it... the RFC is quite hard to follow but at the core it's only really a couple of chained HMAC operations, if memory serves, and there are a load of test vectors.

@karel-m
Copy link
Member Author

karel-m commented Oct 3, 2018

No problem, it can wait a month (or two).

@rmw42
Copy link
Contributor

rmw42 commented Oct 4, 2018

OK, pretty sure I can find the time to do this, then 😄

@danzadok
Copy link

Hi,
I also would like to have this rfc6979 support.
Has it already implemented.

@rmw42
Copy link
Contributor

rmw42 commented Dec 31, 2018

Hi @danzadok!

Sorry, some stuff came up at the end of last year and I wasn't able to work on it. I've read through all the details in the RFC and I'm working on it now :)

@danzadok
Copy link

danzadok commented Dec 31, 2018 via email

@danzadok
Copy link

danzadok commented Jan 17, 2019 via email

@danzadok
Copy link

Hi
I really need this feature. Can someone help me to implement it?

@rmw42 rmw42 mentioned this issue Jan 19, 2019
2 tasks
@rmw42
Copy link
Contributor

rmw42 commented Jan 19, 2019

Sorry, I've been really short on time recently :(
This is as far as I've got so far: #477

It's still not working correctly, I need to dig into the results of the hash chain and check that it's coming up with the correct results/keys.

bbrtj added a commit to Perl-Bitcoin/Bitcoin-Crypto that referenced this issue Jan 26, 2019
Deterministic signatures should be added in future versions of
Libtomcrypt, which is used by CryptX. Ticket link:
libtom/libtomcrypt#441
@bbrtj
Copy link

bbrtj commented Jul 5, 2019

Hey, any news? Is anyone working on this?

@joakim-tjernlund
Copy link

This seems stalled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants