Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky rate limit integration tests #7695

Open
aarongable opened this issue Sep 4, 2024 · 0 comments
Open

Fix flaky rate limit integration tests #7695

aarongable opened this issue Sep 4, 2024 · 0 comments

Comments

@aarongable
Copy link
Contributor

We've observed flaky failures of two integration tests, both of which were touched by #7666.

Failure of the rate limit test:

--- FAIL: TestCertificatesPerDomain (2.88s)
    ratelimit_test.go:57: Somehow managed to issue third certificate: expected error but received none

Failure of the otel tracing test:

did not find span boulder-wfe2::sa.StorageAuthorityReadOnly/GetRegistration with parent 'd292b31fcf42ec85'
did not find span boulder-wfe2::redis.pipeline get with parent 'c0502d9ccfbdf9f2'
did not find span boulder-wfe2::/acme/new-order with parent '13522f69f46460f8'
did not find span integration.test::TraceTest with parent ''
--- FAIL: TestTraces (13.76s)
    otel_test.go:278: Failed to find expected spans in Jaeger for trace e0c52d9859552f2cca98df72bbd2ab36

I suspect that these are related, both because they showed up at the same time shortly after #7666 landed, and because they both concern rate limits: the span that the otel trace is looking for is part of the redis ratelimit lookup code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant